fix(package): fix brittle tests #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAdshead
reviewed
Jun 17, 2021
package.json
Outdated
| @@ -8,7 +8,7 @@ | |||
| "test:lint": "eslint ./ --ignore-path .gitignore --ext .js", | |||
| "test:lockfile": "lockfile-lint -p package-lock.json -t npm -a npm -o https: -c -i", | |||
| "test:git-history": "commitlint --from origin/main --to HEAD", | |||
| "test:unit": "jest", | |||
| "test:unit": "NODE_ENV=production jest", | |||
There was a problem hiding this comment.
do you know which was the brittle test ? ideally any test that relies on NODE_ENV being set to production should have it set so within the test
There was a problem hiding this comment.
Likely the last PR that went in, not sure why the build passed on the PR though
There was a problem hiding this comment.
yeah the last PR that went in, it didn't fail because we set the node_env properties on github workflows for tests but that is not the case for the release workflows
JAdshead
approved these changes
Jun 17, 2021
infoxicator
approved these changes
Jun 17, 2021
|
🎉 This PR is included in version 3.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failing tests on the release process due to missing NODE_ENV value
Description
Motivation and Context
How Has This Been Tested?
Types of Changes
Checklist:
What is the Impact to Developers Using babel-preset-amex?