feat(compute-key): add support for mapKeyToCacheKey #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this option allows consumers to directly vary their cache key
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a693a07:
|
Co-authored-by: Matthew Mallimo <matthew.c.mallimo@aexp.com>
Matthew-Mallimo
previously approved these changes
Feb 28, 2023
10xLaCroixDrinker
requested changes
Feb 28, 2023
10xLaCroixDrinker
requested changes
Feb 28, 2023
Co-authored-by: Jamie King <jamie.king@aexp.com>
Co-authored-by: Jamie King <jamie.king@aexp.com>
10xLaCroixDrinker
requested changes
Mar 1, 2023
| @@ -58,4 +67,55 @@ describe('computeKey', () => { | |||
| }; | |||
| expect(computeKey('uri', firstOptions).hash).toBe(computeKey('uri', secondOptions).hash); | |||
| }); | |||
|
|
|||
| it('should return a different, stable hash, if the option mapKeyToCacheKey is passed', () => { | |||
There was a problem hiding this comment.
This test cannot assert that the key is different as the spec states since it only generates one key. There is nothing to compare it to
| expect(computeHash).toHaveBeenCalledWith(['ABCD-optionKeyValue', { optionKeyMock: 'optionKeyValue' }], { respectType: false }); | ||
| }); | ||
|
|
||
| it('should return the same key if the option mapKeyToCacheKey returns the same string as the key', () => { |
There was a problem hiding this comment.
This test has the same issue as the one on line 71
Matthew-Mallimo
approved these changes
Mar 2, 2023
JAdshead
approved these changes
Mar 3, 2023
10xLaCroixDrinker
approved these changes
Mar 6, 2023
|
@code-forger , thanks this is very promising. how does this work with the SSR request? namely, const fetchye = makeOneServerFetchye({ store, fetchClient });is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this option allows consumers to directly vary their cache key
Motivation and Context
This change enables more advanced caching features, where the cached data is not directly tied to a single complete url.
How Has This Been Tested?
unit tests, run locally in a module.
This is a non-breaking change. No existing unit test was changed of fails.
Types of Changes
Checklist:
What is the Impact to Developers Using Fetchye?
New functionality