Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reduxProvider): dependency array had bad entry #73

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

Matthew-Mallimo
Copy link
Member

Description

The dependency array for the useEffect in makeUseFetchyeSelector included a functional reference that was only updated when the key changes. In certain circumstances where data fetching is started by another process (not useFetchye), this useEffect would fail to run once the data was returned.

Implementing this actually reduced the number of renders.

Motivation and Context

This change correctly reruns the useEffect when data has changed.

How Has This Been Tested?

Unit tests, and manual testing.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Fetchye?

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cf4e462:

Sandbox Source
quick-install Configuration
fetchye-provider-install Configuration
fetchye-redux-provider-install Configuration
nextjs-fetchye-ssr Configuration

code-forger
code-forger previously approved these changes Apr 5, 2023
JAdshead
JAdshead previously approved these changes Apr 5, 2023
Copy link
Member

@10xLaCroixDrinker 10xLaCroixDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test that fails without this fix

@10xLaCroixDrinker 10xLaCroixDrinker merged commit 69ae888 into main Apr 5, 2023
@10xLaCroixDrinker 10xLaCroixDrinker deleted the fix/makeUseFetchyeSelector branch April 5, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants