Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mapOptionToKey): provide first helper #87

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

code-forger
Copy link
Member

Description

Some common use cases for the mapOptionToKey option can be covered by simple helpers

Motivation and Context

Provide simple ways to achieve common patterns.

How Has This Been Tested?

Unit tests

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Fetchye?

Cleaner pattern for achieving this common usecase.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@code-forger code-forger requested a review from a team October 11, 2023 12:16
JAdshead
JAdshead previously approved these changes Oct 11, 2023
Base automatically changed from feat/dynamic-headers to main October 20, 2023 20:40
@10xLaCroixDrinker 10xLaCroixDrinker dismissed stale reviews from JAdshead and Matthew-Mallimo October 20, 2023 20:40

The base branch was changed.

@code-forger code-forger force-pushed the feat/map-options-to-key-helpers branch from b6fd12e to f51a68c Compare October 23, 2023 10:45
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Guy Mac <hello@guymac.eu>
@code-forger code-forger reopened this Oct 23, 2023
@code-forger code-forger merged commit 9202e22 into main Oct 23, 2023
7 checks passed
@code-forger code-forger deleted the feat/map-options-to-key-helpers branch October 23, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants