This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
feat(errors): clarify messaging for collection fetch errors #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtomcal
suggested changes
Apr 27, 2020
There was a problem hiding this comment.
This is super helpful @markbello! This is a great help to us to make our tools a better experience. Thank you!
One nit:
feat(errors): clarify messaging for collection fetch errors should be fix(errors): clarify messaging for collection fetch errors as it is not a new feature but a non breaking fix. This will increment as a patch version.
markbello
force-pushed
the
feat/improve-error-messaging
branch
from
43d9aa0
to
e983fe1
Compare
mtomcal
approved these changes
Apr 27, 2020
JAdshead
approved these changes
Apr 27, 2020
infoxicator
approved these changes
Apr 28, 2020
|
🎉 This PR is included in version 1.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves messaging around collection fetch errors.
It took a lot of head-scratching to figure out why I kept getting an error on
queryCollection()calls. I kept trying every variation on ids I could send in my request, wondering why a successful network response would give me an Iguazu error.It turned out the API I was consuming was sending back an array of objects that didn't have unique identifiers, and not that I was sending in a bad id with my Iguazu call.
The updated messaging should help future users diagnose more easily that the shape of their network response is the problem, rather than the shape of their Iguazu request