This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Chore/contributor guidelines #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10xLaCroixDrinker
suggested changes
Feb 5, 2020
README.md
Outdated
Comment on lines
245
to
246
| This hook verifies that your commit message matches the One Amex conventions. See the **commit | ||
| message** section in the [contribution guidelines](./CONTRIBUTING.md). |
There was a problem hiding this comment.
Looks like you forgot to remove this
There was a problem hiding this comment.
this still needs to be removed
There was a problem hiding this comment.
looks like i had missed this, thank you
mtomcal
suggested changes
Feb 5, 2020
10xLaCroixDrinker
suggested changes
Feb 7, 2020
README.md
Outdated
Comment on lines
245
to
246
| This hook verifies that your commit message matches the One Amex conventions. See the **commit | ||
| message** section in the [contribution guidelines](./CONTRIBUTING.md). |
There was a problem hiding this comment.
this still needs to be removed
10xLaCroixDrinker
approved these changes
Feb 10, 2020
JAdshead
approved these changes
Feb 12, 2020
mtomcal
approved these changes
Feb 17, 2020
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.