Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

add list of input objects as args #36

Conversation

bpillai
Copy link
Contributor

@bpillai bpillai commented Oct 12, 2018

  1. added to code to add a list of input object as part of the argument .
  2. Unable to test the query string . Just checking for null . needs to be looked at .

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 50

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 98.715%

Totals Coverage Status
Change from base Build 49: 0.003%
Covered Lines: 461
Relevant Lines: 467

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 12, 2018

Pull Request Test Coverage Report for Build 51

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 98.715%

Totals Coverage Status
Change from base Build 49: 0.003%
Covered Lines: 461
Relevant Lines: 467

💛 - Coveralls

Copy link
Contributor

@chemdrew chemdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, please just enable the one test case and then we can merge

@chemdrew chemdrew merged commit 698a495 into americanexpress:master Oct 12, 2018
@chemdrew
Copy link
Contributor

I’ll release an update to jcenter in a bit

@chemdrew
Copy link
Contributor

@bpillai artifact has been released to jcenter, version 0.1.3 includes the fix to the list of InputObjects as an argument parameter

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants