This repository has been archived by the owner on May 15, 2024. It is now read-only.
feat(one-app-runner): add #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anescobar1991
force-pushed
the
feature/add-one-app-runner
branch
from
b50ab39
to
c92c777
Compare
JAdshead
suggested changes
Mar 16, 2020
enuchi
reviewed
Mar 16, 2020
JAdshead
previously approved these changes
Mar 17, 2020
nellyk
reviewed
Mar 17, 2020
nellyk
reviewed
Mar 17, 2020
nellyk
reviewed
Mar 17, 2020
nellyk
reviewed
Mar 17, 2020
nellyk
reviewed
Mar 17, 2020
nellyk
reviewed
Mar 17, 2020
nellyk
approved these changes
Mar 17, 2020
JAdshead
approved these changes
Mar 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding one-app-runner to allow for users developing One App modules to run an instance of One App without having to clone, install, and build One App.
one-app-runner uses the One App docker image that we publish (or will start to publish) on every One App release and handles all of the logic for serving modules, using parrot mocks, etc...
It allows modules to have an
npm startscript in their package.json file that can be used to run their module within a real One App instance.