Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

docs(readme): soften language around disabling purgecss #554

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

smackfu
Copy link
Member

@smackfu smackfu commented Jul 25, 2023

Description

Soften up the language around disabling purgecss.

Motivation

Unless I'm misunderstanding, "the effect of disabling will have a negative impact on performance" does not seem accurate to me. If a module uses minimal CSS, and some of it is being incorrectly stripped out by purgecss, disabling purgecss seems like a straightforward way to fix the issue, and scary language doesn't help here.

Types of changes

Check boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist

Check boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

@JAdshead JAdshead requested a review from a team July 25, 2023 22:34
@10xLaCroixDrinker 10xLaCroixDrinker merged commit ab9e6de into main Jul 25, 2023
7 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the smackfu-patch-1 branch July 25, 2023 22:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants