This repository has been archived by the owner on May 15, 2024. It is now read-only.
feat(one-app-runner): add option to load jaeger all-in-one #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces new option to one-app-runner
--include-jaeger
I also did a significant refactor/cleanup
packages/one-app-runner/__tests__/bin/one-app-runner.spec.js
jest.isolateModules
instead ofjest.resetModules
packages/one-app-runner/__tests__/src/startApp.spec.js
packages/one-app-runner/bin/one-app-runner.js
'--no-module-map-url': 'modules'
addition toimplies
eliminates need for global require of yargs'create-docker-network': 'docker-network-to-join'
toimplies
eliminates need for argument validation instartApp.js
packages/one-app-runner/src/startApp.js
objectToFlags
largely eliminates the need for one off arg generation functions and expressions likename ?`--name=${name}` : null
dockerNetworkToJoin
validation to yargs in bin/one-app-runnerpackages/one-app-runner/src/startJaeger.js
PreProcessLogsTransform
stream changes the log levels to use numbers instead of strings so that pino-pretty can drop correctly drop levels we don't want logged (info and debug)-e=JAEGER_DISABLED
should take care of this but it does not. left it in hopes that can be resolvedtreaceresponse
so we can ignore that as well, preventing us from getting in a loop checking the traces for our own requests.Motivation
Allow one-app users to view traces locally
Test Conditions
Ran one-app-runner with
--include-jaeger
with and without--docker-network-to-join
Ran one-app-runner with
--include-jaeger
and a sub-v6.11.0 versionRan one-app-runner without
--include-jaeger
Validated in that span debug logs and requests to jaeger API are not creating a loop.
Types of changes
Check boxes that apply:
Checklist
Check boxes that apply: