fix(errorHandler): application errors would result in a 200 response (#…

…1243)
americanexpress · Jan 23, 2024 · 26a7740 · 26a7740
1 parent badbd98
commit 26a7740
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/__tests__/server/ssrServer.spec.js b/__tests__/server/ssrServer.spec.js
@@ -676,6 +676,7 @@ describe('ssrServer', () => {
         '"Fastify application error: method get, url "/example", correlationId "undefined", headersSent: false [Error: testing]"'
       );
       expect(renderStaticErrorPage).toHaveBeenCalledWith(request, reply);
+      expect(reply.code).toHaveBeenCalledWith(500);
     });
 
     test('setErrorHandler logs an error and renders the static error page with "headersSent" and "correlationId"', async () => {
@@ -709,6 +710,7 @@ describe('ssrServer', () => {
         '"Fastify application error: method get, url "/example", correlationId "123", headersSent: true [Error: testing]"'
       );
       expect(renderStaticErrorPage).toHaveBeenCalledWith(request, reply);
+      expect(reply.code).toHaveBeenCalledWith(500);
     });
   });
 });
diff --git a/src/server/ssrServer.js b/src/server/ssrServer.js
@@ -227,6 +227,7 @@ async function appPlugin(fastify) {
 
     request.log.error('Fastify application error: method %s, url "%s", correlationId "%s", headersSent: %s', method, url, correlationId, headersSent, error);
 
+    reply.code(500);
     return renderStaticErrorPage(request, reply);
   });
 }