fix(watchLocalModules): wait for change to finish (#285)

americanexpress · Aug 25, 2020 · a27d4ba · a27d4ba
1 parent 5503a03
commit a27d4ba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/__tests__/server/utils/watchLocalModules.spec.js b/__tests__/server/utils/watchLocalModules.spec.js
@@ -79,7 +79,7 @@ describe('watchLocalModules', () => {
 
   it('should watch the modules directory', () => {
     watchLocalModules();
-    expect(chokidar.watch).toHaveBeenCalledWith(path.resolve(__dirname, '../../../static/modules'));
+    expect(chokidar.watch).toHaveBeenCalledWith(path.resolve(__dirname, '../../../static/modules'), { awaitWriteFinish: true });
   });
 
   it('should update the module registry when a server bundle changes', async () => {

diff --git a/src/server/utils/watchLocalModules.js b/src/server/utils/watchLocalModules.js
@@ -36,14 +36,13 @@ export default function watchLocalModules() {
   const staticsDirectoryPath = path.resolve(__dirname, '../../../static');
   const moduleDirectory = path.resolve(staticsDirectoryPath, 'modules');
   const moduleMapPath = path.resolve(staticsDirectoryPath, 'module-map.json');
-  const watcher = chokidar.watch(moduleDirectory);
+  const watcher = chokidar.watch(moduleDirectory, { awaitWriteFinish: true });
 
   watcher.on('change', async (changedPath) => {
     if (!changedPath.endsWith('.node.js')) return;
 
     const match = changedPath.substring(moduleDirectory.length).match(/\/([^/]+)\/([^/]+)/);
     if (!match) return;
-
     const [, moduleNameChangeDetectedIn] = match;
 
     const moduleMap = JSON.parse(fs.readFileSync(moduleMapPath, 'utf8'));