fix(env): don't require ONE_ENABLE_POST_TO_MODULE_ROUTES to be set (#738

)

__tests__/server/config/env/runTime.spec.js

@@ -457,9 +457,11 @@ describe('runTime', () => {
       expect(enablePostToModuleRoutes.defaultValue).toBe('false');
     });
 
-    it('should normalize the value to lower case', () => {
-      expect(enablePostToModuleRoutes.normalize('Value')).toBe('value');
-      expect(enablePostToModuleRoutes.normalize('VALUE')).toBe('value');
+    it('should normalize the value to be either true or false', () => {
+      expect(enablePostToModuleRoutes.normalize('Value')).toBe('true');
+      expect(enablePostToModuleRoutes.normalize('VALUE')).toBe('true');
+      expect(enablePostToModuleRoutes.normalize('true')).toBe('true');
+      expect(enablePostToModuleRoutes.normalize('FALSE')).toBe('false');
     });
 
     it('should pass validation when value is "true" or "false"', () => {
@@ -493,11 +495,5 @@ describe('runTime', () => {
       process.env.ONE_ENABLE_POST_TO_MODULE_ROUTES = true;
       expect(() => postRequestMaxPayload.validate('20kb')).not.toThrow();
     });
-
-    it('should fail validation when POSTing is not enabled', () => {
-      expect(() => postRequestMaxPayload.validate('20kb')).toThrowErrorMatchingInlineSnapshot(
-        '"ONE_ENABLE_POST_TO_MODULE_ROUTES must be \\"true\\" to configure max POST payload."'
-      );
-    });
   });
 });

docs/api/server/Environment-Variables.md

@@ -614,7 +614,7 @@ ONE_ENABLE_POST_TO_MODULE_ROUTES=false
 * ✅ Production
 * ✅ Development
 
-Maximum payload allowed in POST requests. `ONE_ENABLE_POST_TO_MODULE_ROUTES` must be true to configure this.
+Maximum payload allowed in POST requests. Has no effect unless `ONE_ENABLE_POST_TO_MODULE_ROUTES` is set to true.
 
 **Shape**
 ```bash

src/server/config/env/runTime.js

@@ -213,7 +213,12 @@ const runTime = [
   {
     name: 'ONE_ENABLE_POST_TO_MODULE_ROUTES',
     defaultValue: 'false',
-    normalize: (input) => input.toLowerCase(),
+    normalize: (input) => {
+      if (input.toLowerCase() === 'false') {
+        return 'false';
+      }
+      return `${!!input}`;
+    },
     validate: (input) => {
       if (input !== 'true' && input !== 'false') {
         throw new Error(`Expected "${input}" to be "true" or "false"`);
@@ -225,10 +230,6 @@ const runTime = [
     name: 'ONE_MAX_POST_REQUEST_PAYLOAD',
     defaultValue: '15kb',
     validate: (input) => {
-      if (process.env.ONE_ENABLE_POST_TO_MODULE_ROUTES !== 'true') {
-        throw new Error('ONE_ENABLE_POST_TO_MODULE_ROUTES must be "true" to configure max POST payload.');
-      }
-
       const parsed = bytes.parse(input);
 
       if (parsed === null) {