Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(initClient): removed StrictMode, resolves #74 #126

Merged
merged 3 commits into from
Apr 30, 2020

Conversation

10xLaCroixDrinker
Copy link
Member

Description

Removed <StrictMode /> from always being wrapped around the app, allowing users to opt in by including it in their modules.

Motivation and Context

Resolves #74

How Has This Been Tested?

I ran the app locally to see that there were no more strict mode related errors in the console with the prod-sample modules

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

There will no longer be errors by default and strict mode will be opt-in only

@10xLaCroixDrinker 10xLaCroixDrinker requested review from a team as code owners April 29, 2020 19:49
@oneamexbot
Copy link
Contributor

oneamexbot commented Apr 29, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 112.6KB 31.4KB
runtime.js 15KB 5.3KB
vendors.js 128.4KB 38KB
app~vendors.js 405.9KB 105.9KB
legacy/app.js 119.3KB 33KB
legacy/runtime.js 15KB 5.3KB
legacy/vendors.js 163.4KB 44.9KB
legacy/app~vendors.js 412KB 107.6KB

Generated by 🚫 dangerJS against bc426c6

@10xLaCroixDrinker 10xLaCroixDrinker merged commit 890a7e8 into master Apr 30, 2020
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/no-strict-mode branch April 30, 2020 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple errors displaying in browser console
6 participants