Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(devCdn): removing extra / which created malformed url #1295

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

dogpatch626
Copy link
Member

Description

fix to the dev cdn which would leave the requested url with two // in front of the incomingRequestPath

Motivation and Context

tested with unit tests

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Copy link
Contributor

github-actions bot commented Feb 14, 2024

Size Change: 0 B

Total Size: 719 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 171 kB
./build/app/app~vendors.js 410 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 123 kB

compressed-size-action

@10xLaCroixDrinker 10xLaCroixDrinker merged commit dba1ac8 into main Feb 15, 2024
9 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the fix/dev-cdn branch February 15, 2024 13:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants