This repository has been archived by the owner on May 3, 2024. It is now read-only.
fix(devCDN): handle different module files #1210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
With the addition of module-config.json, holocron now loads two files per module. These files were triggering the simple 'remove duplicates' functionality. This was the cause of the 'removed file from cache' spam on startup, and effectively neutralised the cache as every file was always getting wiped.
Instead, now consider every part of the url except the version when detecting conflicts, allowing for two different file names to be treated differently
How Has This Been Tested?
run against multiple tenancies
unit tests
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
Faster app startup, less log spam