Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(one-app-router): update to 1.1.0 #137

Merged
merged 6 commits into from
May 14, 2020
Merged

Conversation

JAdshead
Copy link
Contributor

Updating to version 1.1.0 of one-app-router

Description

Updating to the latest version of one app router

Motivation and Context

enables matchPromise, a proimisified version of the match api
removes UNSAFE_lifecycle methods from the router context.

How Has This Been Tested?

Unit and integration tests.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Can make use of one-app-routers matchPromise

@JAdshead JAdshead requested review from a team as code owners May 11, 2020 18:56
@oneamexbot
Copy link
Contributor

oneamexbot commented May 11, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 113.2KB 31.6KB
runtime.js 15KB 5.4KB
vendors.js 128.4KB 38KB
app~vendors.js 433.9KB 112.5KB
service-worker-client.js 16.9KB 5.2KB
legacy/app.js 120KB 33.2KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 163.4KB 44.9KB
legacy/app~vendors.js 442.2KB 114.7KB
legacy/service-worker-client.js 17.4KB 5.4KB

Generated by 🚫 dangerJS against 9600cb2

Copy link
Contributor

@mtomcal mtomcal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So RouterContext was updated with matchPromise? We don't have to do anything from a Module Developer perspective to have errors go away?

@JAdshead
Copy link
Contributor Author

So RouterContext was updated with matchPromise? We don't have to do anything from a Module Developer perspective to have errors go away?

This does not drop all UNSAFE_* errors but has removed a couple

Copy link
Contributor

@infoxicator infoxicator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain how did matchPromisified or match throw the UNSAFE_* console errors? I can't find the relationship, (but also I didn't know we had our own version of matchPromise in one-app either 😅)

jest.mock('../../../src/universal/utils/matchPromisified');
// const { browserHistory } = jest.requireActual('@americanexpress/one-app-router');

// jest.mock('@americanexpress/one-app-router');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these 2 comments intended here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed - 16dff60

@JAdshead
Copy link
Contributor Author

JAdshead commented May 12, 2020

Can you explain how did matchPromisified or match throw the UNSAFE_* console errors? I can't find the relationship, (but also I didn't know we had our own version of matchPromise in one-app either 😅)
@infoxicator the one-app-router release included more than the matchPromise
#137 (review)

@JAdshead JAdshead merged commit 0139c6c into master May 14, 2020
@JAdshead JAdshead deleted the feat/update-one-app-router branch May 14, 2020 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants