-
Notifications
You must be signed in to change notification settings - Fork 84
Conversation
📊 Bundle Size Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So RouterContext
was updated with matchPromise
? We don't have to do anything from a Module Developer perspective to have errors go away?
This does not drop all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain how did matchPromisified
or match
throw the UNSAFE_*
console errors? I can't find the relationship, (but also I didn't know we had our own version of matchPromise in one-app either 😅)
jest.mock('../../../src/universal/utils/matchPromisified'); | ||
// const { browserHistory } = jest.requireActual('@americanexpress/one-app-router'); | ||
|
||
// jest.mock('@americanexpress/one-app-router'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these 2 comments intended here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed - 16dff60
|
Updating to version 1.1.0 of one-app-router
Description
Updating to the latest version of one app router
Motivation and Context
enables
matchPromise
, a proimisified version of the match apiremoves UNSAFE_lifecycle methods from the router context.
How Has This Been Tested?
Unit and integration tests.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
Can make use of one-app-routers matchPromise