This repository has been archived by the owner on May 3, 2024. It is now read-only.
feat(make-promises-safe): treat unhandledRejection as uncaught exception #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAdshead
force-pushed
the
feat/make-promises-safe
branch
from
195e3de
to
9b9c536
Compare
JAdshead
force-pushed
the
feat/make-promises-safe
branch
from
9b9c536
to
587bb46
Compare
📊 Bundle Size Report
|
infoxicator
reviewed
Jun 10, 2020
| @@ -17,6 +17,7 @@ | |||
| import 'core-js/stable'; | |||
| import 'regenerator-runtime/runtime'; | |||
| import 'cross-fetch/polyfill'; | |||
| import 'make-promises-safe'; | |||
There was a problem hiding this comment.
Cool that works just by importing the module!
There was a problem hiding this comment.
This basically adds a event handler on unhandledRejection that calls process.exit(1).
infoxicator
approved these changes
Jun 10, 2020
nellyk
approved these changes
Jun 10, 2020
10xLaCroixDrinker
approved these changes
Jun 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Installed and imported make-promises-safe
Motivation and Context
Node does not crash if there is an 'unhandledRejection', i.e. a Promise without a .catch() handler. This causes a memory leak, make-promises-safe installs an process.on('unhandledRejection') handler that prints the stacktrace and exits the process with an exit code of 1, just like any uncaught exception.
How Has This Been Tested?
Locally running one-app serving frank-lloyd-root. Unit and integration tests.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
None