Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

The config from the root module should be more flexible #20

Closed
10xLaCroixDrinker opened this issue Jan 24, 2020 · 0 comments · Fixed by #38
Closed

The config from the root module should be more flexible #20

10xLaCroixDrinker opened this issue Jan 24, 2020 · 0 comments · Fixed by #38
Assignees
@JamesSingleton

Comments

@10xLaCroixDrinker
Copy link
Member

The env vars are parsed, so they are not always strings

https://github.com/americanexpress/one-app/blob/master/src/server/utils/stateConfig.js#L23-L37

The config from the root module should be more flexible

Originally posted by @10xLaCroixDrinker in #19
@JamesSingleton JamesSingleton self-assigned this Feb 13, 2020
JamesSingleton pushed a commit that referenced this issue Feb 13, 2020
feat(stateConfig): make state config more flexible
c338d0e 
This allows the provideStateConfig to accept more than an object
or a string.

Closes #20
@JamesSingleton JamesSingleton mentioned this issue Feb 13, 2020
Merged
JamesSingleton pushed a commit that referenced this issue Feb 26, 2020
feat(stateConfig): make state config more flexible (#38)
72539a0 
This allows the provideStateConfig to accept more than an object
or a string.

Closes #20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JamesSingleton JamesSingleton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(stateConfig): make state config more flexible americanexpress/one-app
2 participants
@10xLaCroixDrinker @JamesSingleton