fix(watchLocalModules): wait for change to finish

[JAdshead]

Description

This ensures that chokidar waits for the the file to be stable before firing change event.

• https://github.com/paulmillr/chokidar#performance see awaitWriteFinish

in some cases some change events will be emitted while the file is being written. In some cases, especially when watching for large files there will be a need to wait for the write operation to finish before responding to a file creation or modification

Motivation and Context

One App crashing when large modules are rebuilt

How Has This Been Tested?

used an oversized root module, was able to produce crashing of one-app 3/4 attemps. After change could not reproduce crash.

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation (adding or updating documentation)
• Dependency update

Checklist:

• My change requires a change to the documentation and I have updated the documentation accordingly.
• These changes should be applied to a maintenance branch.
• This change requires cross browser checks.
• Performance tests should be ran against the server prior to merging.
• This change impacts caching for client browsers.
• This change impacts HTTP headers.
• This change adds additional environment variable requirements for One App users.
• I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Should no longer crash when large modules are rebuilt.

[oneamexbot]

📊 Bundle Size Report

file name	size on disk	gzip
app.js	275.4KB	82.2KB
runtime.js	15KB	5.4KB
vendors.js	117.2KB	36.4KB
app~vendors.js	432.5KB	112.2KB
service-worker-client.js	17KB	5.2KB
legacy/app.js	290.7KB	85.4KB
legacy/runtime.js	15KB	5.4KB
legacy/vendors.js	163.4KB	44.7KB
legacy/app~vendors.js	441.3KB	114.5KB
legacy/service-worker-client.js	17.5KB	5.4KB

Generated by 🚫 dangerJS against 8617184