Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(holocron-module-route): updates dep returns promises #413

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented Jan 21, 2021

Description

Updates holocron and holocron-module-route which include the following fixes:

holocron fix: moduleLoadStatus 'loading' even with no load or loadModuleData
holocron module route fix: return promises

Motivation and Context

Errors thrown when evaluating ModuleRoute properties kill the server Issue: #213

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@JAdshead JAdshead requested review from a team as code owners January 21, 2021 21:43
@github-actions github-actions bot added the fix label Jan 21, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2021

📊 Bundle Size Report

file name size on disk gzip
app.js 276KB 81.5KB
runtime.js 15.6KB 5.5KB
vendors.js 124.8KB 38.3KB
app~vendors.js 429.9KB 112.4KB
service-worker-client.js 17.1KB 5.3KB
legacy/app.js 296.4KB 86KB
legacy/runtime.js 15.6KB 5.5KB
legacy/vendors.js 183.1KB 49.5KB
legacy/app~vendors.js 453.5KB 118.3KB
legacy/service-worker-client.js 17.6KB 5.5KB

Generated by 🚫 dangerJS against ed82a0a

@JAdshead JAdshead merged commit 6aa086a into main Jan 28, 2021
@JAdshead JAdshead deleted the fix/holocron branch January 28, 2021 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants