This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 84
feat(externals): add flag to not throw if externals semver have mismatch #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle Size Report
|
This requires more than unit tests. What scenarios have you run in a development environment? |
I have also run this locally. Tested:
|
JAdshead
reviewed
Oct 4, 2021
JAdshead
reviewed
Oct 11, 2021
Co-authored-by: Jonny Adshead <JAdshead@users.noreply.github.com>
aa87d19
to
bbbdf19
Compare
10xLaCroixDrinker
approved these changes
Oct 22, 2021
JAdshead
approved these changes
Oct 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new flag, DANGEROUSLY_ACCEPT_BREAKING_EXTERNALS, that when set
true
, will log a warning instead of throwing an error whenever a mismatch in version for externals is detected.Motivation and Context
When upgrading versions of
providedExternals
set by your route module, it can be frustrating because one-app will fail to start up because it throws an error when mismatching external versions are found. If the app is already running, module map polling will fail.The DANGEROUSLY_ACCEPT_BREAKING_EXTERNALS flag will prevent this from happening by logging a warning instead of throwing an error.
This is a dangerous flag to set because mismatching versions can cause unexpected behaviors for modules, and should only be used during a transition of external versions.
How Has This Been Tested?
unit tested
Types of Changes
Checklist:
What is the Impact to Developers Using One App?