Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

test(integration): use otel logging in prod sample #1257

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

10xLaCroixDrinker
Copy link
Member

@10xLaCroixDrinker 10xLaCroixDrinker commented Jan 25, 2024

Description

Use OTel logging in prod-sample/integration tests

Motivation and Context

With OTel logging being the determined way forward, we should be using it in our integration tests

How Has This Been Tested?

npm run test:integration

Ran prod sample locally and observed logs coming through otel-collector

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

N/A

Copy link
Contributor

github-actions bot commented Jan 25, 2024

Size Change: 0 B

Total Size: 712 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 164 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 123 kB

compressed-size-action

@10xLaCroixDrinker 10xLaCroixDrinker marked this pull request as ready for review January 25, 2024 02:32
Copy link
Member

@giulianok giulianok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team January 25, 2024 03:04
@Matthew-Mallimo Matthew-Mallimo merged commit 67ddfca into main Jan 25, 2024
9 checks passed
@Matthew-Mallimo Matthew-Mallimo deleted the feature/prod-sample-otel-logging branch January 25, 2024 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants