This repository has been archived by the owner on May 3, 2024. It is now read-only.
feat(prod-sample): deploy module util #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAdshead
force-pushed
the
feat/prod-sample-utils
branch
from
d0e85cb
to
8f9c95f
Compare
📊 Bundle Size Report
|
mtomcal
reviewed
Sep 17, 2020
| @@ -29,6 +29,7 @@ | |||
| "test:lockfile": "lockfile-lint -p package-lock.json -t npm -a npm -o https: -c -i", | |||
| "test:lint": "eslint --ext js,jsx,md,snap .", | |||
| "start": "node lib/server/index.js", | |||
| "start:inspect": "node --inspect --expose-gc lib/server/index.js", | |||
| "test:unit": "jest --testPathIgnorePatterns integration --config jest.config.js", | |||
There was a problem hiding this comment.
No convenient npm script for this functionality?
There was a problem hiding this comment.
this gives us that npm run start:inspect ?
There was a problem hiding this comment.
npm run serve:prod-sample-module ../some-test-module?
| await fs.ensureDir(pathToOriginModuleStatics); | ||
| await fs.copy(pathToModuleBuildDir, pathToOriginModuleStatics, { overwrite: true }); | ||
| return pathToOriginModuleStatics; | ||
| }; |
There was a problem hiding this comment.
Would this update while the local production server is running?
| moduleName, | ||
| moduleVersion, | ||
| envVars: sanitizedEnvVars, | ||
| }); |
There was a problem hiding this comment.
Is this needed to override the development build created after install?
There was a problem hiding this comment.
yeah this ensures the build is run with NODE_ENV=production
https://github.com/americanexpress/one-app/pull/308/files#diff-db5dfce483b0c43f844c909e42e27356R72
Co-authored-by: Mike Tobia <Francois-Esquire@users.noreply.github.com>
mtomcal
approved these changes
Sep 22, 2020
Francois-Esquire
approved these changes
Sep 22, 2020
infoxicator
approved these changes
Sep 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a util script for deploying modules to
prod-sample.Motivation and Context
To aid testing modules running in production
How Has This Been Tested?
Locally served modules to
prod-sampleTypes of Changes
Checklist:
What is the Impact to Developers Using One App?