Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): export getParams function #209

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

smackfu
Copy link
Member

@smackfu smackfu commented Apr 17, 2023

Description

Export the getParams utility function.

Fixes #208

Motivation and Context

More complex scenarios that use the match function which use route parameters will need to parse the parameters out of the url. Currently this requires either writing custom code, copying the getParams function from parrot-core, or adding an additional dependency. Exporting it directly is better than any of these options.

How Has This Been Tested?

Ran npm pack and then imported into a parrot scenario.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using parrot?

Do not need to bring in another import to parse route parameters out of urls.

@smackfu smackfu requested a review from a team as a code owner April 17, 2023 17:22
@Matthew-Mallimo Matthew-Mallimo requested a review from a team April 17, 2023 17:46
@JAdshead JAdshead merged commit dbcbcd5 into americanexpress:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getParams from parrot-core should be exposed
3 participants