Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 5.0.0 #218

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

maxb08
Copy link
Contributor

@maxb08 maxb08 commented Aug 21, 2023

Description

The release workflow was referencing the name of a job copied from another repo, but here it's called "prepare". Updated the argument reference and the friendly name of the referenced job so that it matches the id more closely.

Motivation and Context

--

How Has This Been Tested?

--

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using parrot?

None

@maxb08 maxb08 requested a review from a team as a code owner August 21, 2023 18:29
@Matthew-Mallimo Matthew-Mallimo merged commit 08a10e6 into americanexpress:main Aug 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants