This repository has been archived by the owner on May 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: various whitelist options replaced with safelist Co-authored-by: Scott McIntyre <scott.mcintyre@aexp.com>
Matthew-Mallimo
approved these changes
May 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename the PR to `upgrade purgecss to version 4, since we are using v4 :)
dogpatch626
changed the title
Feat/upgrade purgecss to version 3
Feat/upgrade purgecss to version 4
May 1, 2023
JAdshead
approved these changes
May 1, 2023
oneamexbot
added a commit
that referenced
this pull request
May 1, 2023
# [4.0.0](v3.0.0...v4.0.0) (2023-05-01) * Feat/upgrade purgecss to version 4 (#63) ([2a847fa](2a847fa)), closes [#63](#63) [#62](#62) ### BREAKING CHANGES * various whitelist options replaced with safelist Co-authored-by: Scott McIntyre <scott.mcintyre@aexp.com> * chore(update-eslint): upgrade eslint related deps and update test format * feat(purgecss): upgrade to purgecss4 * feat(purgecss): add to gitignore * feat(purgecss): fix gitignore
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: various whitelist options replaced with safelist
Description
Upgrade purgecss to version 4.
Motivation and Context
Fixes #54
Release notes for purgecss 3, which describe the change from whitelist to safelist:
https://github.com/FullHuman/purgecss/releases/tag/v3.0.0
Release notes for purgecss 4, which describe the drop of support for postcss4:
https://github.com/FullHuman/purgecss/releases/tag/v4.0.0
How Has This Been Tested?
Updated unit tests to pass.
Types of Changes
Checklist:
What is the Impact to Developers Using Purgecss-Loader?
This resolves a security issue. Developers will need to update their configurations.