Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Feat/upgrade purgecss to version 4 #63

Merged
merged 5 commits into from
May 1, 2023
Merged

Conversation

dogpatch626
Copy link
Member

@dogpatch626 dogpatch626 commented Apr 27, 2023

BREAKING CHANGE: various whitelist options replaced with safelist

Description

Upgrade purgecss to version 4.

Motivation and Context

Fixes #54

Release notes for purgecss 3, which describe the change from whitelist to safelist:
https://github.com/FullHuman/purgecss/releases/tag/v3.0.0

Release notes for purgecss 4, which describe the drop of support for postcss4:
https://github.com/FullHuman/purgecss/releases/tag/v4.0.0

How Has This Been Tested?

Updated unit tests to pass.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Purgecss-Loader?

This resolves a security issue. Developers will need to update their configurations.

dogpatch626 and others added 2 commits April 27, 2023 12:20
BREAKING CHANGE: various whitelist options replaced with safelist

Co-authored-by: Scott McIntyre <scott.mcintyre@aexp.com>
@dogpatch626 dogpatch626 requested review from Matthew-Mallimo and a team May 1, 2023 13:16
.gitignore Outdated Show resolved Hide resolved
@dogpatch626 dogpatch626 requested review from Matthew-Mallimo and a team May 1, 2023 13:23
Copy link
Member

@Matthew-Mallimo Matthew-Mallimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename the PR to `upgrade purgecss to version 4, since we are using v4 :)

@Matthew-Mallimo Matthew-Mallimo requested a review from a team May 1, 2023 13:45
@dogpatch626 dogpatch626 changed the title Feat/upgrade purgecss to version 3 Feat/upgrade purgecss to version 4 May 1, 2023
@dogpatch626 dogpatch626 merged commit 2a847fa into main May 1, 2023
1 check passed
@dogpatch626 dogpatch626 deleted the feat/upgrade-purgecss branch May 1, 2023 22:33
oneamexbot added a commit that referenced this pull request May 1, 2023
# [4.0.0](v3.0.0...v4.0.0) (2023-05-01)

* Feat/upgrade purgecss to version 4 (#63) ([2a847fa](2a847fa)), closes [#63](#63) [#62](#62)

### BREAKING CHANGES

* various whitelist options replaced with safelist

Co-authored-by: Scott McIntyre <scott.mcintyre@aexp.com>

* chore(update-eslint): upgrade eslint related deps and update test format

* feat(purgecss): upgrade to purgecss4

* feat(purgecss): add to gitignore

* feat(purgecss): fix gitignore
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency on vulnerable version of postcss
4 participants