Skip to content

Commit

Permalink
word-at-a-time: avoid undefined behaviour in zero_bytemask macro
Browse files Browse the repository at this point in the history
The asm-generic, big-endian version of zero_bytemask creates a mask of
bytes preceding the first zero-byte by left shifting ~0ul based on the
position of the first zero byte.

Unfortunately, if the first (top) byte is zero, the output of
prep_zero_mask has only the top bit set, resulting in undefined C
behaviour as we shift left by an amount equal to the width of the type.
As it happens, GCC doesn't manage to spot this through the call to fls(),
but the issue remains if architectures choose to implement their shift
instructions differently.

An example would be arch/arm/ (AArch32), where LSL Rd, Rn, linux-sunxi#32 results
in Rd == 0x0, whilst on arch/arm64 (AArch64) LSL Xd, Xn, linux-sunxi#64 results in
Xd == Xn.

Rather than check explicitly for the problematic shift, this patch adds
an extra shift by 1, replacing fls with __fls. Since zero_bytemask is
never called with a zero argument (has_zero() is used to check the data
first), we don't need to worry about calling __fls(0), which is
undefined.

Cc: <stable@vger.kernel.org>
Cc: Victor Kamensky <victor.kamensky@linaro.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
wildea01 authored and torvalds committed Apr 27, 2014
1 parent ac6c9e2 commit ec6931b
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions include/asm-generic/word-at-a-time.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,7 @@ static inline bool has_zero(unsigned long val, unsigned long *data, const struct
}

#ifndef zero_bytemask
#ifdef CONFIG_64BIT
#define zero_bytemask(mask) (~0ul << fls64(mask))
#else
#define zero_bytemask(mask) (~0ul << fls(mask))
#endif /* CONFIG_64BIT */
#endif /* zero_bytemask */
#define zero_bytemask(mask) (~0ul << __fls(mask) << 1)
#endif

#endif /* _ASM_WORD_AT_A_TIME_H */

0 comments on commit ec6931b

Please sign in to comment.