This repository has been archived by the owner on Apr 18, 2022. It is now read-only.
Simplify mouse axis, only one radius value would ever be used for a given config #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2099 +/- ##
=========================================
Coverage ? 83.57%
=========================================
Files ? 80
Lines ? 5942
Branches ? 0
=========================================
Hits ? 4966
Misses ? 976
Partials ? 0
Continue to review full report at Codecov.
|
AnneKitsune
approved these changes
Jan 20, 2020
|
bors r=@Jojolepro |
bors bot
added a commit
that referenced
this pull request
Jan 20, 2020
2099: Simplify mouse axis, only one radius value would ever be used for a given config r=jojolepro a=Xaeroxe ## Description For a mouse input axis one of the two radial values is guaranteed to go unused, so this simplifies the structure. ## Additions - amethyst_input::Axis::Mouse::radius ## Removals - amethyst_input::Axis::Mouse::radius_x - amethyst_input::Axis::Mouse::radius_y ## Modifications - N/A ## PR Checklist By placing an x in the boxes I certify that I have: - N/A Updated the content of the book if this PR would make the book outdated. - [x] Added a changelog entry if this will impact users, or modified more than 5 lines of Rust that wasn't a doc comment. - N/A Added unit tests for new code added in this PR. - [x] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme. If this modified or created any rs files: - [x] Ran `cargo +stable fmt --all` - [x] Ran `cargo clippy --all --features "empty"` - [x] Ran `cargo test --all --features "empty"` Co-authored-by: Jacob Kiesel <kieseljake@gmail.com>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For a mouse input axis one of the two radial values is guaranteed to go unused, so this simplifies the structure.
Additions
Removals
Modifications
PR Checklist
By placing an x in the boxes I certify that I have:
If this modified or created any rs files:
cargo +stable fmt --allcargo clippy --all --features "empty"cargo test --all --features "empty"