Skip to content
This repository has been archived by the owner on Apr 18, 2022. It is now read-only.

Broadcaster is lacking features #74

Closed
Emilgardis opened this issue Jul 19, 2016 · 2 comments
Closed

Broadcaster is lacking features #74

Emilgardis opened this issue Jul 19, 2016 · 2 comments
Labels
type: feature A request for a new feature.

Comments

@Emilgardis
Copy link
Contributor

With PR #67, there is no way to access the world, which would have made it possible to add resources, Systems and the native functions of a World. This needs to be fixed in some way.

Currently, Broadcaster only provides some sugar for World.
Emilgardis added a commit to Emilgardis/amethyst that referenced this issue Jul 19, 2016
@Emilgardis
Exposing World.
e0222fa 
Exposing it makes it possible to add Systems, known as Processors in
`amethyst::ecs`. This also exposes every native function.

A problem with this approach is that it is not optimal, simply using World
instead of Broadcast in `Context` is also not optimal. See amethyst#67 and amethyst#74.
@Emilgardis
Copy link
Contributor Author

cc @nchashch

@nchashch
Copy link
Member

It would still be impossible to add Systems because it would require a Planner that needs to own the World, so it won't be possible to move the World from Broadcaster while calling Planner::new(). And I am not sure if there are use cases for exposing resource creation, access functionality.

I also think that it would make sense to keep entities in Broadcaster read only, since they represent events and it adds the guarantee that the event you publish will be the same event when it is polled.

@nchashch nchashch added type: invalid type: feature A request for a new feature. and removed type: invalid labels Aug 10, 2016
@ebkalderon ebkalderon added this to Shipped in Engine Feb 3, 2017
@ebkalderon ebkalderon removed this from Shipped in Engine Feb 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: feature A request for a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Emilgardis @nchashch