This repository has been archived by the owner on Apr 18, 2022. It is now read-only.
Improvement/reexport ui image load prefab #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excludes `amethyst_ui/src/button/mod.rs` as clippy cannot detect the usage of certain imports inside the macro.
7 tasks
Codecov Report
@@ Coverage Diff @@
## master #2181 +/- ##
==========================================
- Coverage 83.9% 83.32% -0.59%
==========================================
Files 74 74
Lines 5996 6074 +78
==========================================
+ Hits 5031 5061 +30
- Misses 965 1013 +48
Continue to review full report at Codecov.
|
|
bors r+ |
Build succeeded |
1 task
7 tasks
bors bot
added a commit
that referenced
this pull request
Jul 7, 2020
2349: Update book example pong-tutorial-06 to fix clippy warning r=CleanCut a=MrTanoshii ## Description Clippy will warn of https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref The examples were already fixed by #2181 but the book was not. ## Additions N/A ## Removals N/A ## Modifications N/A ## PR Checklist By placing an x in the boxes I certify that I have: - [x] Updated the content of the book if this PR would make the book outdated. - [ ] Added a changelog entry if this will impact users, or modified more than 5 lines of Rust that wasn't a doc comment. - [ ] Added unit tests for new code added in this PR. - [x] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme. If this modified or created any rs files: - [x] Ran `cargo +stable fmt --all` - [x] Ran `cargo clippy --all --features "empty"` - [x] Ran `cargo test --all --features "empty"` Co-authored-by: MrTanoshii <47116127+MrTanoshii@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2169 with amended docs and clippy fixes.
PR Checklist
By placing an x in the boxes I certify that I have:
If this modified or created any rs files:
cargo +stable fmt --allcargo +stable clippy --all --features "vulkan"cargo test --all --features "vulkan"