This repository has been archived by the owner on Apr 18, 2022. It is now read-only.
Fix clippy, don't deny warnings #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the new warnings introduced in 1.46.0 update. Also had to remove `--deny warnings` as discussed (link in PR comment)
|
cc @Blisto91 |
Blisto91
approved these changes
Aug 29, 2020
There was a problem hiding this comment.
Good man!
@CleanCut I'm gonna merge this because I think it makes sense in the short term. In the longer term we can still aim for disallowing warnings.
Maybe a temporary compromise could be to create an easy overview of the amount and type of warnings on the repo.
Could be a separate workflow or a badge counting/linking to the warnings.
Then they could still be in focus without forcing a quick scramble when something new pops up.
|
bors r+ |
ezpuzz
added
the
type: maintenance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the new warnings introduced in 1.46.0 update.
Also had to remove
--deny warningsas discussed: #2450 (comment)PR Checklist
By placing an x in the boxes I certify that I have:
If this modified or created any rs files:
cargo +stable fmt --allcargo clippy --workspace --features "empty"(may requirecargo cleanbefore)cargo build --features "empty"cargo test --workspace --features "empty"