Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upIntegrate RON #269
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Xaeroxe
Aug 4, 2017
Member
looks good to me, but for some reason the documentation is failing to generate?
|
looks good to me, but for some reason the documentation is failing to generate? |
kvark
approved these changes
Aug 4, 2017
This is nuts:
- ~400 LOC removed
- cleaner actual configuration files
- less macro magic on the Rust side
/me
| + #[serde(default)] | ||
| + pub multisampling: u16, | ||
| + /// Sets the visibility of the window. | ||
| + #[serde(default = "true")] |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
torkleyy
Aug 4, 2017
Member
Yeah, I know that it doesn't work yet. For whatever reason it accepts a function name. I'll try to make a PR for #[serde(default_value=...)].
torkleyy
Aug 4, 2017
Member
Yeah, I know that it doesn't work yet. For whatever reason it accepts a function name. I'll try to make a PR for #[serde(default_value=...)].
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Xaeroxe
Aug 4, 2017
Member
@torkleyy https://serde.rs/attr-default.html Woops, it doesn't seem to like specifying default literals like that.
|
@torkleyy https://serde.rs/attr-default.html Woops, it doesn't seem to like specifying default literals like that. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Xaeroxe
Aug 4, 2017
Member
@torkleyy While we wait for the default_value suggestion to land, how do you feel about the commit I made just now?
|
@torkleyy While we wait for the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
And now we have another problem :/ |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Ah. serde_derive doesn't work without serde. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@Xaeroxe stable travis passed, neat |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Yeah, we can use it for now. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
But examples won't work right now. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@torkleyy mind if I fix them? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@torkleyy torkleyy#1 Merge if you please |
Xaeroxe
approved these changes
Aug 4, 2017
Works great! Ready to merge as far as I'm concerned.
torkleyy commentedAug 4, 2017
No description provided.