Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate RON #269

Merged
merged 6 commits into from Aug 6, 2017
Merged

Integrate RON #269

merged 6 commits into from Aug 6, 2017

Conversation

@torkleyy
Copy link
Member

@torkleyy torkleyy commented Aug 4, 2017

No description provided.

@Xaeroxe
Copy link
Member

@Xaeroxe Xaeroxe commented Aug 4, 2017

looks good to me, but for some reason the documentation is failing to generate?

Loading

kvark
kvark approved these changes Aug 4, 2017
Copy link
Member

@kvark kvark left a comment

This is nuts:

  • ~400 LOC removed
  • cleaner actual configuration files
  • less macro magic on the Rust side

/me 😍 it!

Loading

#[serde(default)]
pub multisampling: u16,
/// Sets the visibility of the window.
#[serde(default = "true")]
Copy link
Member

@kvark kvark Aug 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it doesn't like this "true". Perhaps, quoting should not be here?

Loading

Copy link
Member Author

@torkleyy torkleyy Aug 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I know that it doesn't work yet. For whatever reason it accepts a function name. I'll try to make a PR for #[serde(default_value=...)].

Loading

@Xaeroxe
Copy link
Member

@Xaeroxe Xaeroxe commented Aug 4, 2017

@torkleyy https://serde.rs/attr-default.html Woops, it doesn't seem to like specifying default literals like that.

Loading

@Xaeroxe
Copy link
Member

@Xaeroxe Xaeroxe commented Aug 4, 2017

@torkleyy While we wait for the default_value suggestion to land, how do you feel about the commit I made just now?

Loading

@Xaeroxe
Copy link
Member

@Xaeroxe Xaeroxe commented Aug 4, 2017

And now we have another problem :/

Loading

@Xaeroxe
Copy link
Member

@Xaeroxe Xaeroxe commented Aug 4, 2017

Ah. serde_derive doesn't work without serde.

Loading

@vitvakatu
Copy link
Contributor

@vitvakatu vitvakatu commented Aug 4, 2017

@Xaeroxe stable travis passed, neat

Loading

@torkleyy
Copy link
Member Author

@torkleyy torkleyy commented Aug 4, 2017

Yeah, we can use it for now.

Loading

@torkleyy
Copy link
Member Author

@torkleyy torkleyy commented Aug 4, 2017

But examples won't work right now.

Loading

@Xaeroxe
Copy link
Member

@Xaeroxe Xaeroxe commented Aug 4, 2017

@torkleyy mind if I fix them?

Loading

@Xaeroxe
Copy link
Member

@Xaeroxe Xaeroxe commented Aug 4, 2017

@torkleyy torkleyy#1 Merge if you please

Loading

Xaeroxe
Xaeroxe approved these changes Aug 4, 2017
Copy link
Member

@Xaeroxe Xaeroxe left a comment

Works great! Ready to merge as far as I'm concerned.

Loading

@Xaeroxe Xaeroxe requested a review from Aug 4, 2017
@Xaeroxe Xaeroxe merged commit a662404 into amethyst:develop Aug 6, 2017
2 checks passed
Loading
@torkleyy torkleyy deleted the ron branch Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants