Integrate RON #269
Integrate RON #269
Conversation
|
looks good to me, but for some reason the documentation is failing to generate? |
src/gfx_device/display_config.rs
Outdated
| #[serde(default)] | ||
| pub multisampling: u16, | ||
| /// Sets the visibility of the window. | ||
| #[serde(default = "true")] |
There was a problem hiding this comment.
I think it doesn't like this "true". Perhaps, quoting should not be here?
There was a problem hiding this comment.
Yeah, I know that it doesn't work yet. For whatever reason it accepts a function name. I'll try to make a PR for #[serde(default_value=...)].
|
@torkleyy https://serde.rs/attr-default.html Woops, it doesn't seem to like specifying default literals like that. |
|
@torkleyy While we wait for the |
|
And now we have another problem :/ |
|
Ah. serde_derive doesn't work without serde. |
|
@Xaeroxe stable travis passed, neat |
|
Yeah, we can use it for now. |
|
But examples won't work right now. |
|
@torkleyy mind if I fix them? |
|
@torkleyy torkleyy#1 Merge if you please |
No description provided.