Skip to content
This repository has been archived by the owner on Apr 18, 2022. It is now read-only.

Feature - Debug lines #957

Merged
merged 22 commits into from Sep 22, 2018
Merged

Feature - Debug lines #957

merged 22 commits into from Sep 22, 2018

Conversation

khskarl
Copy link
Member

@khskarl khskarl commented Sep 21, 2018

Continuing #941

Just added Aceeri suggestions.

@khskarl
Implemented a pass using geometry shaders to render lines, but still …
3298763 
…using arbitrary meshes' vertices and normals as position and direction
@khskarl
Removed unnecessary information derived from base code for the debug …
6ad6358 
…lines pass
@khskarl
Added PosColorNorm vertex format.
5be311b 
It's useful for rendering lines efficiently.
@khskarl
Changed separate pass into interleaved pass.
7a42996 
Fixed example's ron file.
@khskarl
Properly implemented PosColorNorm VertexFormat, finally?
235a0f9
@khskarl
Got simple 1px jagged ugly lines rendering, with colors!
49d031a
@khskarl
Variable line width added
26f8505
@khskarl
Fixed geometry shader and 'debug lines' pass to use Points as primiti…
c7c4575 
…ves instead of triangles
@khskarl
Added back face culling
e702484
@khskarl
Fixed lines rendering to always face towards the camera
47e165b
@khskarl
Added barebones grid rendering
d95b763
@khskarl
Subgrid working, now every grid cell is subdivided by 10x10 cells
182432e
@khskarl
Cleaned up comments and old code
e3662f0
@khskarl
Added 'DebugLines' resource for short term lines
fbb7b10
@khskarl
Debug lines as component and resource work!
f578742
@khskarl
Added debug lines as component and resource;
d20fdfe 
Created key bindings config file
@khskarl
Ran cargo fmt
b1d4f16
@khskarl
Various readability and code style tweaks.
4feb322 
Added comment explaining reasoning for the line width.
@khskarl
Changed raw arrays in add_as_line and add_as_direction to cgmath's Po…
c59d92b 
…int3 and Vector3.
@khskarl
DebugLines component is now persistent and won't clear lines in DrawD…
24957fc 
…ebugLines render pass.

Separated DebugLines struct into separate struct for component and resource, to have more intuitive and meaningful function names that map correctly to their different behaviors.
@khskarl
Aceeri review.
b14dc72 
Removed all `with_transparency` references, cleaner syntax and consistency fixes.
@LucioFranco LucioFranco added type: feature A request for a new feature. team: rendering labels Sep 21, 2018
Aceeri
Aceeri approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

@Aceeri Aceeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to fix that merge issues in the CHANGELOG.md

docs/CHANGELOG.md Show resolved Hide resolved
@AnneKitsune
Copy link
Contributor

Thanks!
bors r+

bors bot added a commit that referenced this pull request Sep 22, 2018
@bors @khskarl
Merge #957
c9cf055 
957: Feature - Debug lines r=jojolepro a=khskarl

Continuing #941

Just added Aceeri suggestions.

Co-authored-by: Karll <karllhenning64@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 22, 2018

Build succeeded

@bors bors bot merged commit 3caa1ee into amethyst:master Sep 22, 2018
@khskarl khskarl deleted the feature/debug-lines branch September 22, 2018 22:12
@khskarl khskarl mentioned this pull request Sep 23, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AnneKitsune AnneKitsune AnneKitsune approved these changes

@Aceeri Aceeri Aceeri approved these changes

Assignees
No one assigned
Labels
team: rendering type: feature A request for a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@khskarl @AnneKitsune @Aceeri @LucioFranco