Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for editing resources #25

Merged
merged 15 commits into from
Oct 21, 2018
Merged

Add support for editing resources #25

merged 15 commits into from
Oct 21, 2018

Conversation

randomPoison
Copy link
Member

This implements basic support for receiving updated data for resources from the editor and applying those updates to the local state. Currently this is only implemented for resources, however the same pattern can be easily implemented for components.

  • Split SyncResourceSystem into ReadResourceSystem and WriteResourceSystem.
  • Add functionality to SyncEditorSystem to read incoming update data and dispatch it to the corresponding WriteResourceSystem.
  • Add the requirement that registered resources be DeserializeOwned. We should add an API for registering read-only resources for when a resource only implements Serialize.
  • Make some tweaks to the pong example so that changes to the ScoreBoard resource show up more immediately (useful for demo purposes).

Lots of easy ways to improve this, but I'd rather get this merged in with the functionality as-is. I'll write up some tickets to track the remainder of the cleanup work, that way others can have a chance to contribute.

@randomPoison
Copy link
Member Author

randomPoison commented Oct 20, 2018

Things I should probably still do before merging:

  • Update docs for public types for sure, probably should also document any new/updated internal types.
  • Fix the TODO for checking the source address for incoming packets.
  • Add tests so that we can use CI to verify that the stuff like making the UDP socket non-blocking works correctly on all platforms.

@randomPoison randomPoison added this to In progress in Runtime editing support Oct 20, 2018
@randomPoison randomPoison merged commit 044c9b2 into master Oct 21, 2018
Runtime editing support automation moved this from In progress to Done Oct 21, 2018
@randomPoison randomPoison deleted the edit-resources branch October 21, 2018 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant