Fix about 30 failing tests against current legion master. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @jaynus @AThilenius |
|
@CleanCut Yeah this repo is pretty well bit-rotted at this point. I'll take a look if I have time this weekend, super busy most days unfortunately (writing C# for Unity, even more unfortunately... I miss Rust 😭) |
You'll make your way back one day! 😢 I'm closing this in favor of the forks which are already ahead of this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add a tiny method to a struct implementation, but I couldn't write any tests because about 30 tests were broken.
So I fixed the tests.
But now the code itself doesn't compile (???) due to one last error, which I am too tired to try to figure out.
Any help fixing the last error outside of tests would be most appreciated, so I can start unwinding and implement the method so I can go back and fix the bug in jlowry-contrib/amethyst#2 so we can keep moving forward with porting the pong example to legion.