Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in WFC tutorial #42

Closed
toyboot4e opened this issue Nov 29, 2019 · 1 comment
Closed

Typo in WFC tutorial #42

toyboot4e opened this issue Nov 29, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@toyboot4e
Copy link

toyboot4e commented Nov 29, 2019

Thank you for your well-written tutorial!

  • Typo in the waveform collapse tutorial: pub fn patterns_to_constaints should be pub fn patterns_to_constraints.

  • Just my curious, but why do you refer to it as "waveform collapse", not "wave function collapse"?

  • Also, this code in the function (patterns_to_constaints)

                    let opposite;
                    match direction {
                        0 => opposite = 1, // Our North, Their South
                        1 => opposite = 0, // Our South, Their North
                        2 => opposite = 3, // Our West, Their East
                        _ => opposite = 2 // Our East, Their West
                    }

may be written as

                    let opposite = match direction {
                        0 => 1, // Our North, Their South
                        1 => 0, // Our South, Their North
                        2 => 3, // Our West, Their East
                        _ => 2, // Our East, Their West
                    };
@thebracket thebracket self-assigned this Nov 30, 2019
@thebracket thebracket added the bug Something isn't working label Nov 30, 2019
@thebracket
Copy link
Collaborator

You're right, it really should be "wave function collapse" rather than "waveform collapse". I saw it as the former once and the name stuck, unfortunately I've repeated the error EVERYWHERE so it may take some time to fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants