Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dispatcher that can be sent between threads #234

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Add a dispatcher that can be sent between threads #234

merged 3 commits into from
Jan 3, 2024

Conversation

Imberflur
Copy link
Contributor

No description provided.

@IsseW
Copy link
Contributor

IsseW commented Jan 3, 2024

Dispatcher seems to now be an extension over SendDispatcher if IIUC.

And I think there would be less code duplication if Dispatcher contained a SendDispatcher instead of the two fields they share.

@Imberflur
Copy link
Contributor Author

Dispatcher seems to now be an extension over SendDispatcher if IIUC.

And I think there would be less code duplication if Dispatcher contained a SendDispatcher instead of the two fields they share.

implemented this!

@Imberflur Imberflur merged commit 5d52c6f into amethyst:master Jan 3, 2024
5 checks passed
@Imberflur Imberflur deleted the send-dispatcher branch January 3, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsseW IsseW IsseW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Imberflur @IsseW