Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framerate independence #43

Open
Jazarro opened this issue Nov 1, 2019 · 3 comments
Open

Framerate independence #43

Jazarro opened this issue Nov 1, 2019 · 3 comments

Comments

@Jazarro
Copy link

Jazarro commented Nov 1, 2019

At the moment, whenever there is a drop in frames the characters noticeably slow down. When running in debug mode, it is common (at least on my laptop) for framerates to occasionally drop down to 30-40 fps. This causes a very noticeable and irritating jank in the characters' movements.

It would be desirable if the movements and animations advanced as a function of time passed, rather than number of frames passed.

  • Entity velocities should be expressed in m/s, rather than m/frame
  • Translation should be updated by adding velocity times delta seconds

I'd like to give this a go, if nobody is working on this yet. Any input is welcome. :)

@krankur
Copy link
Member

krankur commented Nov 2, 2019

@ABoschman Thanks for logging this issue. This is a must have feature. Though somehow I neither logged an issue for it nor worked on it (kept putting it off actually). Glad that you brought it up and want to work on it. Much appreciated. Assigned it to you.

On a different note, I noticed that your name doesn't show in the contributor's list. It seems like you have set a different email id for this repository than the one you have set for your GitHub account. You might want to use the same email id at both places or add the one that is set for the repository as well to your GitHub account, in case you want your name to show up in the contributors' list. In case its intentional, please ignore. Just want to make sure that you are aware of it.

@Jazarro
Copy link
Author

Jazarro commented Nov 2, 2019

No, I didn't know it worked like that. I was wondering why I didn't show up in the contributors list. GitHub does seem to identify those commits as mine. Weird.

@krankur
Copy link
Member

krankur commented Nov 2, 2019

Yeah, even I had faced the same issue. But seems like you have updated your email id as the contributors count has gone up to 6 and it shows your name if you hover over the count. GitHub still doesn't show your name when on the contributors page though, which is strange. But it should show up there as well if you make any new commits now onward. At least that's what I observed in my case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants