Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep version consistent, correct feature flag #694

Merged
merged 1 commit into from May 28, 2020
Merged

keep version consistent, correct feature flag #694

merged 1 commit into from May 28, 2020

Conversation

stevensonmt
Copy link
Contributor

@stevensonmt stevensonmt commented Apr 5, 2020 •
edited

Could not compile with features = ["derive"]. Needed it to be features = ["specs-derive"].

@stevensonmt
keep version consistent, correct feature flag
4666a00 
Could not compile with `features = ["derive"]`. Needed it to be `features = ["specs-derive"]`.
azriel91
azriel91 approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@azriel91 azriel91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ✌️

@azriel91
Copy link
Member

oh by the way, the "derive" feature would be available in the next version (it's on master) -- so hopefully not a surprise if you see this change half reverted 🙂.

bors r+

@bors
Copy link
Contributor

bors bot commented May 28, 2020

Build succeeded:

@bors bors bot merged commit 7a2e348 into amethyst:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azriel91 azriel91 azriel91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stevensonmt @azriel91