Delete components after killing entities to avoid clearing components when the entity has the wrong generation #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esn't clear components
… on an entity with the wrong generation. Also removed some spots that redudantly try to ensure that `MetaTable<dyn AnyStorage>>` is available since it is always inserted in `WorldExt::new`.
… doesn't need to follow it and it should be faster, add cargo-deny exception for Unicode-DFS-2016 license in unicode-ident
|
I was about to ping @Imberflur to discuss this, then realised you'd just changed your profile picture 😀 |
zesterer
approved these changes
Jun 6, 2023
dev-dependencies, since we will need to bump the MSRV for other reasons soon enough)
xMAC94x
reviewed
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[ ] I've added a demonstration of the new feature to one or more examples[ ] I've updated the book to reflect my changes[ ] Usage of new public items is shown in the API docsAPI changes
WorldExt::delete_entitiesmethod now includes the index of the entity with the wrong generation to indicate to the user where it stopped (since entities after that are not deleted).