Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events: Migrate subdomains to subfolders #26

Merged
merged 3 commits into from
Dec 13, 2019
Merged

Events: Migrate subdomains to subfolders #26

merged 3 commits into from
Dec 13, 2019

Conversation

lohitha02
Copy link
Contributor

@lohitha02 lohitha02 commented Dec 11, 2019 •
edited by vibhoothi
Loading

vibhoothi
vibhoothi suggested changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@vibhoothi vibhoothi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thank you for this patch, much needed,

I would like to have the package.json changes into a new commit

And also updating the description with relevant links.

Apart from that LGTM

package.json Outdated Show resolved Hide resolved
vibhoothi
vibhoothi suggested changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@vibhoothi vibhoothi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A rough idea of commit history should be
1 Updating package.json
2 Events: mlh-local-hackday, mlh-build-day, Hacktoeberfest
3 utils: dataFetch another commit

So we would not be having 2k+ changes in a single commit
Also, update the commit message with some description

Update: It might be better if we have all the events changes in a single commit.

@vibhoothi
Copy link
Contributor

Hi,
Can you please rebase to latest master.

@lohitha02
Updating package.json
4d967e5
@lohitha02
Events: Migrate events into sub-folders
406696f 
This commit adds the following events viz.
  - Hacktoberfest 2019
  - MLH-hack-day
  - MLH-build-day
This also adds the following images:
  - Amrita logo
  - amFOSS logo
@lohitha02
utils: import dataFetch
1ebd60f
vibhoothi
vibhoothi approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@vibhoothi vibhoothi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vibhoothi vibhoothi merged commit e6737ce into amfoss:master Dec 13, 2019
This was referenced Dec 13, 2019
Closed
Closed
@lohitha02 lohitha02 mentioned this pull request Dec 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibhoothi vibhoothi vibhoothi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start migrating the subdomains to subfolders
2 participants
@lohitha02 @vibhoothi