Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New search type searchCustom #5

Closed
wants to merge 6 commits into from
Closed

Conversation

elhay-av
Copy link

To allow search with custom conditions. like

(item.propA > target && item.propB < target)

To allow search with custom conditions. like 
```
(item.propA > target && item.propB < target)
```
@coveralls
Copy link

Coverage Status

Coverage decreased (-12.1%) to 86.301% when pulling 777987b on elhay-av:patch-1 into f2c2345 on amgadfahmi:master.

@amgadfahmi
Copy link
Owner

@elhay-av would you please provide a unit testing by updating the specs file as coverage has been dropped to 86%

@amgadfahmi
Copy link
Owner

Also have a look on the following as iterator will be discontinued https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator
Keep performance in consideration as well, thanks

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.08%) to 97.333% when pulling 6e12e59 on elhay-av:patch-1 into f2c2345 on amgadfahmi:master.

@coveralls
Copy link

coveralls commented Jul 27, 2016

Coverage Status

Coverage decreased (-1.08%) to 97.333% when pulling 6e12e59 on elhay-av:patch-1 into f2c2345 on amgadfahmi:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.08%) to 97.333% when pulling b50f136 on elhay-av:patch-1 into f2c2345 on amgadfahmi:master.

@elhay-av
Copy link
Author

Also have a look on the following as iterator will be discontinued https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator
Keep performance in consideration as well, thanks

Iterator not relevant here sance most browsers (Chrome, IE, safari, opera) not supported this function

and when i mention Iterator in my code it just a function with some compare condition that exec on any item in the collection.

@elhay-av elhay-av closed this Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants