Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story 25 #130

Merged
merged 8 commits into from
Sep 18, 2017
Merged

Story 25 #130

merged 8 commits into from
Sep 18, 2017

Conversation

randy-darsh
Copy link
Collaborator

Related Issue: #3

Summary: Add functionality for admin to edit items information

Author(s): randy-darsh and big dawg Joel Lindow

@randy-darsh randy-darsh changed the base branch from master to development September 18, 2017 22:47
Copy link
Collaborator

@JoelLindow JoelLindow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope Sam changes the redirects. Looks good otherwise

Copy link
Owner

@amhursh amhursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will merge shortly.


def update
@item = Item.find(params[:id])
if @item.update(item_params)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work. We can discuss a different redirect (the actual image page that was updated) but I kind of like this the way it is.


<%= f.label :status %>
<%= f.select :status, ["active", "retired"] %>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice an clean.

@amhursh amhursh merged commit a35a1e8 into development Sep 18, 2017
@amhursh amhursh removed the review label Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants