Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pihole web v5.18 requires auth on all API endpoints now #45

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

sergekh42
Copy link
Contributor

Pihole web v5.18 requires auth on all API endpoints now except for version and type. I am not a Swift dev, don't know how to compile and test these changes.

PR that caused this change - pi-hole/web#2411
Pihole release - https://github.com/pi-hole/AdminLTE/releases/v5.18

Since upgrading to the Pihole web v5.18, PiBar no longer works. Only the test connection function returns true.
Screenshot 2022-12-23 at 10 57 31 AM
Screenshot 2022-12-23 at 10 57 48 AM

Pihole web v5.18 now requires all endpoints to have auth except for versions, version, and type.
Copy link
Owner

@amiantos amiantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason this shouldn't do the job... LGTM. I'll test locally and make some other changes and get a release up.

@amiantos amiantos merged commit 6f3755f into amiantos:master Jan 5, 2023
@sergekh42
Copy link
Contributor Author

Verified that the new release is working, thank you!

@sergekh42 sergekh42 deleted the fix_pihole_auth branch January 5, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants