Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot all observed values, rather than non-(over)imputed values. #54

Merged
merged 2 commits into from May 17, 2022

Conversation

thomvolker
Copy link
Member

@thomvolker thomvolker commented May 17, 2022

PR for #39

Maybe it's an idea to check whether users input an incomplete dataset for plot_flux() and plot_pattern() functions, because these are only sensible when the data set contains missings.

I will check the in-built mice functions whether they can easily accommodate synthetic data.

@hanneoberman
Copy link
Member

Thanks Thom! The other thing you mention is actually already included in issue #44, but thanks for the reminder :)

@hanneoberman hanneoberman merged commit 8ca6dbd into amices:main May 17, 2022
@hanneoberman
Copy link
Member

@thomvolker what's your orcid? I'll add you as contributor to the package description!

@thomvolker
Copy link
Member Author

thomvolker commented May 17, 2022

Awesome, thanks! 😃

0000-0002-2408-7820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants