Pass extra arguments mice.impute.rf() to ranger::ranger() #563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR allows to pass
...
arguments toranger::ranger()
when usingmice.impute.rf()
....
was only being passed along whenrfPackage = "randomForest"
; should want the same behaviour with the now defaultrfPackage = "ranger"
.fit
toranger::ranger(x = xobs, y = yobs, num.trees = ntree, ...)
, but this triggers unused arguments warning for "type" (which I think is passed along to allmice.impute.method
functions?). Hence, I uselist(...)
, setextra_ranger_args[["type"]] <- NULL
, and proceed withdo.call()
to avoid this warning.ranger()
arguments (e.g.mtry
) can affect the quality of the imputations quite a bit.