Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preeq_wrms and posteq_wrms values are zero with FSA #2066

Closed
plakrisenko opened this issue May 4, 2023 · 1 comment
Closed

preeq_wrms and posteq_wrms values are zero with FSA #2066

plakrisenko opened this issue May 4, 2023 · 1 comment
Assignees

Comments

@plakrisenko
Copy link
Collaborator

The values should be equal to "weighted root-mean-square of the rhs when steady state was reached".

I get values equal to "0.0" in case
solver.setSensitivityOrder(amici.SensitivityOrder_first)
amici_solver.setSensitivityMethod(SensitivityMethod.forward)
amici_solver.setNewtonMaxSteps(0)
amici_model.setSteadyStateSensitivityMode(amici.SteadyStateSensitivityMode.integrationOnly).
However, in case I use SensitivityMethod.adjoint I get values different from "0.0", e.g. "0.91".

  • AMICI version: 0.16.1

I suppose, it's related to the line here
https://github.com/AMICI-dev/AMICI/blob/master/src/steadystateproblem.cpp#L711

I think, in the end the output of getWrmsFSA is saved to preeq_wrms (or posteq_wrms), not output of getWrms. Not sure why it's always "0.0", though. I tried with different tolerances, fsa tolerances.

@dweindl
Copy link
Member

dweindl commented May 8, 2023

I think, in the end the output of getWrmsFSA is saved to preeq_wrms (or posteq_wrms), not output of getWrms.

Correct.

Agreed that this doesn't match the current documentation at

AMICI/include/amici/rdata.h

Lines 332 to 336 in 1a99308

/**
* weighted root-mean-square of the rhs when steadystate
* was reached (preequilibration)
*/
realtype preeq_wrms = NAN;

or

AMICI/include/amici/rdata.h

Lines 343 to 347 in 1a99308

/**
* weighted root-mean-square of the rhs when steadystate
* was reached (postequilibration)
*/
realtype posteq_wrms = NAN;

@dweindl dweindl self-assigned this May 9, 2023
@dweindl dweindl closed this as completed in 252da79 May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants