Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Model.setAlwaysCheckFinite(True) in tests #2235

Closed
dweindl opened this issue Dec 12, 2023 · 2 comments · Fixed by #2262
Closed

Use Model.setAlwaysCheckFinite(True) in tests #2235

dweindl opened this issue Dec 12, 2023 · 2 comments · Fixed by #2262
Assignees
@dweindl
Labels
ci

Comments

@dweindl
Copy link
Member

dweindl commented Dec 12, 2023

Would have helped to discover/fix #2231/#2234 earlier...
@dweindl dweindl added the ci label Dec 12, 2023
@dweindl
Copy link
Member Author

dweindl commented Dec 18, 2023

Is it okay to automatically set Model.setAlwaysCheckFinite(True) if ENABLE_AMICI_DEBUGGING=TRUE?

@FFroehlich
Copy link
Member

yes!

@dweindl dweindl self-assigned this Jan 6, 2024
dweindl added a commit to dweindl/AMICI that referenced this issue Jan 6, 2024
@dweindl
Use Model.setAlwaysCheckFinite(True) in debug builds
2e1c039 
So that we automatically use the additional checks in our tests.

Closes AMICI-dev#2235
@dweindl dweindl mentioned this issue Jan 6, 2024
Merged
@dweindl dweindl linked a pull request Jan 6, 2024 that will close this issue
Use Model.setAlwaysCheckFinite(True) in debug builds #2262
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Model.setAlwaysCheckFinite(True) in debug builds dweindl/AMICI
2 participants
@FFroehlich @dweindl