Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessor macros #25

Closed
dweindl opened this issue Sep 12, 2016 · 1 comment
Closed

Accessor macros #25

dweindl opened this issue Sep 12, 2016 · 1 comment

Comments

@dweindl
Copy link
Member

dweindl commented Sep 12, 2016

The current accessor macros in [eur]data.h are causing trouble when including header files with function prototypes having arguments with the same names as the accessor macros (not unlikely with names as "p" or "k"). This becomes a pain in the ass when including external libraries and using AMICI-generated C-code in bigger projects.
Although tedious, what do you think about prefixing the accessor functions with "AMI(CI)_" and/or write them in uppercase to be clearly identifiable as preprocessor macros?
@dweindl
Copy link
Member Author

dweindl commented Sep 13, 2016

Solved for now. Moved to separate headers to be included in .c but not in .h. Solves most problems. 472702f

@dweindl dweindl closed this as completed Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dweindl